Attention is currently required from: neels, pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32217 )

Change subject: bsc: add TC_mscpool_sccp_n_pcstate_attaches_msc
......................................................................


Patch Set 1:

(2 comments)

File bsc/BSC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32217/comment/98113a55_0d64ef45
PS1, Line 9190:         pars1.mscpool.l3_info := 
valueof(ts_LU_REQ(LU_Type_IMSI_Attach, 
valueof(ts_MI_IMSI_LV('001010420000001'H)), '00F110'O));
> What's changing here? I'm unable to find out :/
Gerrit used to highlight only specific parts being changed, but now this 
appears to be broken.
The IMSI is changing: '001010000000001' -> '001010420000001'.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32217/comment/709e3594_1b901f51
PS1, Line 9211:         pars3.mscpool.l3_info := 
valueof(ts_PAG_RESP(valueof(ts_MI_IMSI_LV('001010420000003'H))));
> this should probably be fixed by having ts_PAG_RESP accept a template (value) 
> as a param.
full ACK



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32217
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib4a5330df30a73e744c316898817b2fa3271d75e
Gerrit-Change-Number: 32217
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 05 Apr 2023 11:41:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to