Attention is currently required from: pespin, fixeria.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/32196 )
Change subject: nm: Drop NM_EV_SETATTR_{ACK/NACK}
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Patchset:
PS4:
LGTM besides the uninitialized rc case that fixeria commented about
File src/osmo-bts-sysmo/oml.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32196/comment/c2fc9090_cae72ace
PS3, Line 1726: case NM_MT_SET_RADIO_ATTR:
> `rc` is uninitialized in this case. I suggest removing it and simply doing
> `return 0` below.
(this is still unresolved)
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32196
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I281c07bb5ad88ee03542f092141cebe036d10aee
Gerrit-Change-Number: 32196
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Wed, 05 Apr 2023 17:10:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment
