laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/32200 )
Change subject: si2quater: bts_uarfcn_add(): check if already added first
......................................................................
si2quater: bts_uarfcn_add(): check if already added first
This way we print the proper message if the given UARFCN is already
added, no matter if the UTRAN neighbour list is full or not.
Change-Id: Ife83023f6a9e28d77e44e4757457d4d1c879e78f
Related: SYS#6401
---
M src/osmo-bsc/system_information.c
1 file changed, 16 insertions(+), 3 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/system_information.c
b/src/osmo-bsc/system_information.c
index 97294f4..c6928d6 100644
--- a/src/osmo-bsc/system_information.c
+++ b/src/osmo-bsc/system_information.c
@@ -302,12 +302,12 @@
*ual = bts->si_common.data.uarfcn_list,
*scl = bts->si_common.data.scramble_list;
- if (len == MAX_EARFCN_LIST)
- return -ENOMEM;
-
if (pos >= 0)
return -EADDRINUSE;
+ if (len == MAX_EARFCN_LIST)
+ return -ENOMEM;
+
/* find the suitable position for arfcn if any */
pos = uarfcn_sc_pos(bts, arfcn, SC_BOUND);
i = (pos < 0) ? len : pos;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32200
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ife83023f6a9e28d77e44e4757457d4d1c879e78f
Gerrit-Change-Number: 32200
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
