Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32222 )
Change subject: Introduce NM FSM for GPRS Cell object ...................................................................... Patch Set 3: (2 comments) File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/32222/comment/abc6d59c_0671b97d PS3, Line 460: osmo_fsm_inst_dispatch(bts->gprs.nse.mo.fi, NM_EV_SW_ACT, NULL); > not sure, but don't you need to add here: […] No, only what are considered "top level" FSM objects are done here (the bts_site_mgr and bts are quite entangled right now, I plan to fix that next). NSE FSM will ev_dispatch_child() to the GPRS CELL. File src/common/nm_gprs_cell_fsm.c: https://gerrit.osmocom.org/c/osmo-bts/+/32222/comment/63161639_073d8253 PS3, Line 47: nse > cell? No, that's intended, we are waiting for the NSE to be enabled here before being able to opstart the GPRS CELL. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5fd1d17da09a5f0eee3d69fcb4788c106a240e21 Gerrit-Change-Number: 32222 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Comment-Date: Thu, 06 Apr 2023 10:26:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Gerrit-MessageType: comment
