Attention is currently required from: fixeria.

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32216 )

Change subject: bsc: add TC_mscpool_sccp_n_pcstate_detaches_msc
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
> Please update `expected-results.xml`.
i added expected-results.xml way back because i was confused by test failures: 
i thought i broke something while jenkins was also failing them. So far my 
workflow is, when i am uncertain about test failures i am seeing in a custom 
test run, then i run 'update_expected_results_from_jenkins.sh'. So personally i 
wouldn't expect all of us to manually keep those files updated, I'd say it is 
sufficient to see a semi regular update of it. After all, the only thing this 
does is print some tests' names in a different color in the test summary 
output. No harm done when a test is shown as "New" for a little while.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32216
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia1aea4e33230d6a685b72ea5ba20dd9c7d265d44
Gerrit-Change-Number: 32216
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Thu, 06 Apr 2023 14:29:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to