fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/32251 )


Change subject: si2quater: check return value of osmo_earfcn_del()
......................................................................

si2quater: check return value of osmo_earfcn_del()

Change-Id: I227dad57737721c40a508f67616d9f5003bb1a3e
Fixes: CID#313584
---
M src/osmo-bsc/bts_vty.c
1 file changed, 14 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/51/32251/1

diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c
index 0ecb6d6..fa8543e 100644
--- a/src/osmo-bsc/bts_vty.c
+++ b/src/osmo-bsc/bts_vty.c
@@ -2078,7 +2078,10 @@

        vty_out(vty, "%% Warning: not enough space in SI2quater (%u/%u used) 
for a given EARFCN %u%s",
                bts->si2q_count, SI2Q_MAX_NUM, arfcn, VTY_NEWLINE);
-       osmo_earfcn_del(e, arfcn);
+
+       if (osmo_earfcn_del(e, arfcn) != 0) {
+               vty_out(vty, "%% Failed to roll-back adding EARFCN %u%s", 
arfcn, VTY_NEWLINE);
+       }

        return CMD_WARNING;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32251
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I227dad57737721c40a508f67616d9f5003bb1a3e
Gerrit-Change-Number: 32251
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-MessageType: newchange

Reply via email to