fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/32297
)
Change subject: pySim-prog.py: fix SyntaxWarning: using is with a literal
......................................................................
pySim-prog.py: fix SyntaxWarning: using is with a literal
Change-Id: If9460bf827242a1dfc518213e3faa9137a21869a
---
M pySim-prog.py
1 file changed, 11 insertions(+), 2 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
msuraev: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/pySim-prog.py b/pySim-prog.py
index b3919ee..448f2a0 100755
--- a/pySim-prog.py
+++ b/pySim-prog.py
@@ -599,9 +599,9 @@
# commandline options we can use that info, otherwise we guess that
# the length is 2, which is also the most common case.
if opts.mnclen != "auto":
- if opts.mnclen is "2":
+ if opts.mnclen == "2":
row['mnc'] = row.get('mnc', mnc_from_imsi(row.get('imsi'),
False))
- elif opts.mnclen is "3":
+ elif opts.mnclen == "3":
row['mnc'] = row.get('mnc', mnc_from_imsi(row.get('imsi'),
True))
else:
raise ValueError("invalid parameter --mnclen, must be 2 or 3
or auto")
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/32297
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: If9460bf827242a1dfc518213e3faa9137a21869a
Gerrit-Change-Number: 32297
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: msuraev <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
