dexter has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/32336 )


Change subject: e1d: fix log output
......................................................................

e1d: fix log output

When a read access to the osmo-e1d fd fails we just prind the error to
LOGL_DEBUG but an error like this should be logged to LOGL_ERROR. Also
the line might print "read error 0 Success", which is a bit misleading,
so let's fix this as well.

Change-Id: I3a0500f083cbe8cc162826e2ec974875bafcaba9
---
M src/input/e1d.c
1 file changed, 15 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/36/32336/1

diff --git a/src/input/e1d.c b/src/input/e1d.c
index 6392b4f..098e488 100644
--- a/src/input/e1d.c
+++ b/src/input/e1d.c
@@ -233,7 +233,7 @@

        ret = read(bfd->fd, msg->data, D_TSX_ALLOC_SIZE);
        if (ret < 0 || ret != D_TSX_ALLOC_SIZE) {
-               LOGPITS(e1i_ts, DLINP, LOGL_DEBUG, "read error  %d %s\n", ret, 
strerror(errno));
+               LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "read error: %d %s\n", ret, 
ret < 0 ? strerror(errno) : "bytes read");
                msgb_free(msg);
                return ret;
        }

--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32336
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I3a0500f083cbe8cc162826e2ec974875bafcaba9
Gerrit-Change-Number: 32336
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-MessageType: newchange

Reply via email to