Attention is currently required from: osmith.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/32367 )

Change subject: CSD: support 29k0, 32k0 transp data
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1:
I think the comment is very mis-leading.  This change doesn't make us magically 
support bit-rates that are beyond the capability of a single timeslot.  
Supporting anything above 14k5 transparent means having to implement 
multi-channel assignments (HSCSD), whihc would have large impact on the channel 
allocator and many other parts of osmo-bsc.  There is no plan or requirement to 
implement HSCSD, so it really would be best not to imply (in code or commit 
log) that we do support it in any way.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32367
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I03fd3ca19b08d5cff8748ba9cf2f21d4befaf338
Gerrit-Change-Number: 32367
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Comment-Date: Thu, 20 Apr 2023 00:14:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to