[S] Change in libosmo-abis[master]: e1d: close fd when osmo_fd_setup fails

[dexter]

dexter has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/32370 )

Change subject: e1d: close fd when osmo_fd_setup fails
......................................................................

e1d: close fd when osmo_fd_setup fails

When osmo_fd_register() fails we just exit but the file descriptor stays
open. A file descriptor in this state does not work. Let's close the file
descriptor

Change-Id: I6b41e5ad8511f2d4e524979631a91ab23dc0b23f
---
M src/input/e1d.c
1 file changed, 15 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved




diff --git a/src/input/e1d.c b/src/input/e1d.c
index f95d493..44a710d 100644
--- a/src/input/e1d.c
+++ b/src/input/e1d.c
@@ -509,6 +509,8 @@
                if (ret < 0) {
                        LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "could not register 
FD: %s\n", strerror(ret));
                        talloc_free(ts_info);
+                       close(bfd->fd);
+                       bfd->fd = -1;
                        return ret;
                }
        }

--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32370
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I6b41e5ad8511f2d4e524979631a91ab23dc0b23f
Gerrit-Change-Number: 32370
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged