Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32360 )
Change subject: ms: Rewrite MS release lifecycle ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/gprs_ms.c: https://gerrit.osmocom.org/c/osmo-pcu/+/32360/comment/af372d21_4c104426 PS5, Line 218: ms_becomes_idle these ms_becomes_ function names sound a bit strange to me, as the other functions are in imperative form and it's not that descriptive imho. maybe ms_schedule_release and ms_cancel_release would be better? but feel free to ignore if you think the existing ones from this patch are better -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibe5115bc15bb4d76026918adc1be79469c2f4839 Gerrit-Change-Number: 32360 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 21 Apr 2023 09:17:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
