Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32392 )
Change subject: e1d: do not set fd number to 0 after close ...................................................................... Patch Set 2: (1 comment) File src/input/e1d.c: https://gerrit.osmocom.org/c/libosmo-abis/+/32392/comment/fb78768b_b28b33f6 PS1, Line 494: if (bfd->fd <= 0) { > these checks can most probably be changed to <, and the "> 0" also can be > changed to ">= 0"? Thanks. I will address that in a different patch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32392 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I72e4775135caf4e3727c4f0654a545478c73bb83 Gerrit-Change-Number: 32392 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 12:50:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
