Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32401 )
Change subject: e1d: initialize file descriptor numbers to -1 on startup ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > note that this is likely not an e1d driver specific issue, but a general > issue, also present wit dah […] It is part of the osmo-e1d crash problem. In this case it really matters since the value of the file descriptor is checked to determine of the file descriptor is currently open (TS is in use) or closed (-1). The checks there would used <= 0 as condition, which is a bit misleading. That is why I fixed this as well. At least DAHDI has similar issues: https://gitea.osmocom.org/osmocom/libosmo-abis/src/branch/master/src/input/dahdi.c#L658 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32401 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2de8fccad56279748ed9cc035aebf4e2d3935172 Gerrit-Change-Number: 32401 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 12:50:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
