Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32436 )
Change subject: layer23: Use OSMO_IMSI_BUF_SIZE from libosmocore ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/32436/comment/2970c8b3_2360c3a7 PS3, Line 8: > I'd mention here that GSM_IMSI_LENGTH was 16, and OSMO_IMSI_BUF_SIZE is 17: > […] Done File src/host/layer23/src/common/subscriber.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32436/comment/491a29f6_1d4382d0 PS3, Line 232: strlen(imsi) - 1 > OSMO_IMSI_BUF_SIZE - 1 > is this still correct? Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32436 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I295444bb3b75ed236ea4af5563d9a9c9e590cab7 Gerrit-Change-Number: 32436 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 14:07:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <[email protected]> Gerrit-MessageType: comment
