Attention is currently required from: dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32290 )
Change subject: mgcp_network: do not deliver RTP packets with unpatched PT ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/32290/comment/34973814_525a87f3 PS3, Line 9: call agent by call agent, do you mean like BSC and MSC? So far I see call agent as meaning a PBX like freeswitch or kamailio. Maybe 'MGCP client'? File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/32290/comment/97bfe5d5_311c677a PS3, Line 1168: DEBUG I guess when we drop packets that would be LOGL_ERROR; only problem is with spamming 20 LOGL_ERROR per second... so maybe NOTICE? definitely DEBUG seems too insignificant when this is the single point of failure for establishing a voice call. (I was thinking before about a mechanism in the MGW, where we sort of remember that previous RTP packets of an endp had identical errors, and we log an error only once, or maybe only once every ten seconds. Just thinking here, does not need to be part of this patch.) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I013a24c1e0f853557257368cfab9192d4611aafa Gerrit-Change-Number: 32290 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 19:44:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
