Attention is currently required from: pespin.

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32362 )

Change subject: hnbgw: add TC_sccp_cr_limit: test CR data length cutoff
......................................................................


Patch Set 1:

(1 comment)

File hnbgw/HNBGW_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32362/comment/c43234a8_615085a6
PS1, Line 625: private function f_build_initial__nas(TestHdlrParams pars, 
octetstring nas)
> why 2 underscores between initial and nas?
I wanted to make it like a "private" function, in C I'd have put a leading 
underscore. But stupid name yes.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32362
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia68dad973ef18513b52f5accb5264c557c7295ea
Gerrit-Change-Number: 32362
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 26 Apr 2023 03:16:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to