[S] Change in osmo-iuh[master]: fix PDU leaks in rua_generate_*() functions

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-iuh/+/32530 )


Change subject: fix PDU leaks in rua_generate_*() functions
......................................................................

fix PDU leaks in rua_generate_*() functions

Related: SYS#6297
Change-Id: I04eb1455e1fd43c239f352470bf971b73eb8b205
---
M src/rua_common.c
1 file changed, 22 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/30/32530/1

diff --git a/src/rua_common.c b/src/rua_common.c
index f21bf8f..37cf3ba 100644
--- a/src/rua_common.c
+++ b/src/rua_common.c
@@ -134,6 +134,7 @@
 {
        RUA_RUA_PDU_t pdu;
        int rc;
+       struct msgb *msg;

        memset(&pdu, 0, sizeof(pdu));

@@ -146,7 +147,9 @@
                return NULL;
        }

-       return _rua_gen_msg(&pdu);
+       msg = _rua_gen_msg(&pdu);
+       ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RUA_RUA_PDU, &pdu);
+       return msg;
 }

 struct msgb *rua_generate_successful_outcome(
@@ -157,6 +160,7 @@
 {
        RUA_RUA_PDU_t pdu;
        int rc;
+       struct msgb *msg;

        memset(&pdu, 0, sizeof(pdu));

@@ -169,7 +173,9 @@
                return NULL;
        }

-       return _rua_gen_msg(&pdu);
+       msg = _rua_gen_msg(&pdu);
+       ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RUA_RUA_PDU, &pdu);
+       return msg;
 }

 struct msgb *rua_generate_unsuccessful_outcome(
@@ -180,6 +186,7 @@
 {
        RUA_RUA_PDU_t pdu;
        int rc;
+       struct msgb *msg;

        memset(&pdu, 0, sizeof(pdu));

@@ -192,7 +199,9 @@
                return NULL;
        }

-       return _rua_gen_msg(&pdu);
+       msg = _rua_gen_msg(&pdu);
+       ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RUA_RUA_PDU, &pdu);
+       return msg;
 }

 RUA_IE_t *rua_new_ie(RUA_ProtocolIE_ID_t id,

--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/32530
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I04eb1455e1fd43c239f352470bf971b73eb8b205
Gerrit-Change-Number: 32530
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-MessageType: newchange