Attention is currently required from: pespin, dexter. matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32498 )
Change subject: ctrl: Add penalty time control ...................................................................... Patch Set 4: (1 comment) File src/osmo-bsc/bts_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/32498/comment/2c9228d7_2c241dca PS4, Line 798: CTRL_CMD_DEFINE(bts_penalty_time, "si3-penalty-time"); > this field seems to be in si_common so I suspec it's used in more than SI3. > […] Actually I don't really need them, I just thought it would be nice to contribute some code to open source. In my very humble opinion perhaps it is ok to keep the same grouping and naming as the VTY (just penalty-time) or maybe under a node of "selection-params"? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idfdd54dec72fb5f52eee22df018161d75b8c48c8 Gerrit-Change-Number: 32498 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: dexter <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Thu, 27 Apr 2023 15:34:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
