Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32532 )
Change subject: pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 (Settable) ...................................................................... Patch Set 8: Code-Review-2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/32532/comment/0a24453e_6a305891 PS8, Line 11: Older versions will ignore the settable_object parameter Are you sure? Have you tested this at all? In `requirements.txt` we require `cmd2==1.5`, which does not like this argument. I quickly tested this patch in docker: ``` Card initialization failed with an exception: ---------------------8<--------------------- Traceback (most recent call last): File "/data/./pySim-shell.py", line 983, in <module> app = PysimApp(card, rs, sl, ch, opts.script) File "/data/./pySim-shell.py", line 148, in __init__ self.add_settable(cmd2.Settable('numeric_path', bool, 'Print File IDs instead of names', self, TypeError: __init__() takes 4 positional arguments but 5 positional arguments (and 1 keyword-only argument) were given ---------------------8<--------------------- ``` Either we maintain backwards compatibility with 1.5 and don't break it, or we finally bump the version (at least to 0.8.5, which is provided by debian:bullseye). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I38efe4702277ee092a5542d7d659df08cb0adeff Gerrit-Change-Number: 32532 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Thu, 27 Apr 2023 16:30:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
