Attention is currently required from: laforge, pespin, msuraev.

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32323 )

Change subject: sccp: allow separate cs7 for IuPS and IuCS
......................................................................


Patch Set 5:

(2 comments)

Patchset:

PS5:
> That's pretty big - shouldn't there be some tests/ additions to ensure things 
> won't fall apart?
I tested with the ttcn3 test suite, first of all whether everything still works 
with a single cs7, same as jenkins, and then i also tested manually with 
separate cs7 instances ... So I tested it (TM) and we can merge it now;

Or, if you reviewers prefer we can first wait for the entire MSC/SGSN pooling 
feature to be complete -- this is only the first step in a yet larger 
refactoring.
I submitted it early because customer wants to use this as a workaround.

For the CN pooling feature, there will be substantial new tests and 
infrastructure in HNBGW_Tests.ttcn and I guess we should configure one or two 
of the MSCs/SGSNs of the CN pool in the ttcn3 tests in separate cs7 instances.

Short answer is: yes, will come =) not part of this patch


PS5:
> What I am missing here is dding a new .cfg file to doc/examples/ showcasing 
> this new possible setup. […]
(i have no idea why this is marked resolved, unresolving now)



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32323
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Iea1824f1c586723d989c80a909bae16bd2866e08
Gerrit-Change-Number: 32323
Gerrit-PatchSet: 5
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-CC: msuraev <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: msuraev <[email protected]>
Gerrit-Comment-Date: Thu, 27 Apr 2023 17:03:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: msuraev <[email protected]>
Gerrit-MessageType: comment

Reply via email to