Attention is currently required from: osmith, pespin.

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/32534 )

Change subject: gb: ns2: Rename parameter name in 
gprs_ns2_nsvc_by_sockaddr_bind()
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2:
> The saddr stands for socket address and not source address.
what about peer_addr? I don't have a strong opinion here.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32534
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3f45a4ef339cadd47920ee3b36c38628b38221f6
Gerrit-Change-Number: 32534
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 28 Apr 2023 00:53:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <[email protected]>
Gerrit-MessageType: comment

Reply via email to