Attention is currently required from: tnt, pespin.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/32569 )

Change subject: e1d: get rid of strange file descriptor registered check
......................................................................


Patch Set 1:

(1 comment)

File src/input/e1d.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/32569/comment/388a121e_6a89d65f
PS1, Line 420:                  continue;
> here you already have a path where the bfd becomes unregistered but keeps >= 
> 0. […]
Hmm. I think in this case lets better call osmo_fd_registered()? the line 
update does not happen very frequently.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32569
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I92c426271dc5455427471030fcf0749566e4c2ee
Gerrit-Change-Number: 32569
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Reviewer: tnt <[email protected]>
Gerrit-Attention: tnt <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 02 May 2023 14:47:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to