Attention is currently required from: pespin, dexter.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/32579 )

Change subject: select: speed up osmo_fd_is_registered
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1:
> You cannot guarantee that a correct pointer won't be LLIST_POISON1.

unfortunately not with its current value.  If the LLIST_POISON1 value ended at 
an odd address, we could make the assumption, given that a pointer to a 
llist_head should never be pointing to an odd address.

But unfortunately 0x00100100 is very nicely aligned for 32/64bit and even 
larger alignments.  So we could indeed end up seeing that address in the wild.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32579
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1ce894da39e3f2329c88666a5dda594b8bce4228
Gerrit-Change-Number: 32579
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Thu, 04 May 2023 00:14:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: dexter <[email protected]>
Gerrit-MessageType: comment

Reply via email to