Attention is currently required from: fixeria.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/32180 )

Change subject: cosmetic: Clarify language ip.access nanoBTS vs. all IPA Abis/IP
......................................................................


Patch Set 2:

(1 comment)

File src/osmo-bsc/bts_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/32180/comment/726e20b9_186d3561
PS2, Line 1923: ipaccess nanoBTS
> I think the logging message is still correct, it's a workaround for some 
> nanoBTS fw versions. […]
well, the command is permitted on such "other Abis/IP BTS".  So either we make 
the command nanoBTS specific (and keep the old log message), or we change the 
logging, IMHO.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32180
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I31696d9a21a799511741a561085686cfa0728f93
Gerrit-Change-Number: 32180
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Thu, 04 May 2023 05:26:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to