Attention is currently required from: pespin.

msuraev has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/32277 )

Change subject: ctrl: drop deprecated neighbor resolution interface
......................................................................


Patch Set 8:

(1 comment)

File src/osmo-bsc/neighbor_ident_ctrl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/32277/comment/d92b42fd_b24d4ad7
PS8, Line 553: /* This and the following: Add/Remove a CGI-PS as neighbor */
> why are you dropping this? This code is independent from the inteface you are 
> removing.
You mean parse_cgi_ps()? It's only used by deprecated ctrl commands which are 
removed by this patch.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32277
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I93e25856eede4b2f5aa36d8a16714b43d37b4fd0
Gerrit-Change-Number: 32277
Gerrit-PatchSet: 8
Gerrit-Owner: msuraev <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 05 May 2023 06:44:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to