Attention is currently required from: markb, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32533 )
Change subject: pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 (include_ipy) ...................................................................... Patch Set 4: (1 comment) File requirements.txt: https://gerrit.osmocom.org/c/pysim/+/32533/comment/481781e4_a5ce1ac8 PS4, Line 13: packaging > You're missing to update `setup.py` and `README` (adding a new dep). And AFAICS, you are using this module in previous patch, but adding the dependency here. You should add it in the first patch actually using it, or in a separate patch. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibc0e18b002a03ed17933be4d0b4f4e86ad99c26e Gerrit-Change-Number: 32533 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: markb <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: markb <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Sat, 06 May 2023 00:34:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
