neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-smlc/+/32622 )
Change subject: ctrl-test: drop bogus 'rm -f $(CTRL_TEST_DB)'
......................................................................
ctrl-test: drop bogus 'rm -f $(CTRL_TEST_DB)'
That is a copy-paste artifact from osmo-hlr.git and looks pretty
dangerous when CTRL_TEST_DB is not defined.
Change-Id: Idcf9296a6e7e520c2f0b42f8aace01d616bcfc56
---
M tests/Makefile.am
1 file changed, 12 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
daniel: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
diff --git a/tests/Makefile.am b/tests/Makefile.am
index b2e1bee..5ced1ea 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -63,13 +63,10 @@
# pass -u to ctrl_script_runner.py by doing:
# make ctrl-test U=-u
ctrl-test: $(top_builddir)/src/osmo-smlc/osmo-smlc
- -rm -f $(CTRL_TEST_DB)
osmo_verify_transcript_ctrl.py -v \
-p 4272 \
-r "$(top_builddir)/src/osmo-smlc/osmo-smlc -c
$(top_srcdir)/tests/osmo-smlc.cfg" \
$(U) $(srcdir)/*.ctrl
- -rm -f $(CTRL_TEST_DB)
- -rm $(CTRL_TEST_DB)-*
check-local: atconfig $(TESTSUITE)
$(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS)
--
To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/32622
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-smlc
Gerrit-Branch: master
Gerrit-Change-Id: Idcf9296a6e7e520c2f0b42f8aace01d616bcfc56
Gerrit-Change-Number: 32622
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
