fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-abis/+/32663 )
Change subject: cosmetic: e1inp_ipa_bts_rsl_close_n(): cache ipa_client_conn
......................................................................
cosmetic: e1inp_ipa_bts_rsl_close_n(): cache ipa_client_conn
Change-Id: I9bdb4b1778d702c97890149a9f98590ae8ec54be
(cherry picked from commit 0de8a853a660f8822c9ce78cb7c3fea558c3c6b3)
---
M src/input/ipaccess.c
1 file changed, 15 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/63/32663/1
diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index 8a52591..114389e 100644
--- a/src/input/ipaccess.c
+++ b/src/input/ipaccess.c
@@ -1206,6 +1206,7 @@
/* Close the underlying IPA TCP socket of an RSL link */
int e1inp_ipa_bts_rsl_close_n(struct e1inp_line *line, uint8_t trx_nr)
{
+ struct ipa_client_conn *conn;
struct ipaccess_line *il;
if (E1INP_SIGN_RSL+trx_nr-1 >= NUM_E1_TS) {
@@ -1218,9 +1219,10 @@
if (!il)
return 0; /* Nothing to do, no lines created */
- if (il->ipa_cli[1 + trx_nr]) {
- ipa_client_conn_close(il->ipa_cli[1 + trx_nr]);
- ipa_client_conn_destroy(il->ipa_cli[1 + trx_nr]);
+ conn = il->ipa_cli[1 + trx_nr];
+ if (conn != NULL) {
+ ipa_client_conn_close(conn);
+ ipa_client_conn_destroy(conn);
il->ipa_cli[1 + trx_nr] = NULL;
}
return 0;
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32663
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: rel-1.4.1
Gerrit-Change-Id: I9bdb4b1778d702c97890149a9f98590ae8ec54be
Gerrit-Change-Number: 32663
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-MessageType: newchange
