Attention is currently required from: laforge, pespin, keith. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32374 )
Change subject: e1d: reconnect to osmo-e1d after connection loss ...................................................................... Patch Set 12: (5 comments) File src/input/e1d.c: https://gerrit.osmocom.org/c/libosmo-abis/+/32374/comment/902eb91d_934437dd PS11, Line 340: osmo_fsm > the question to me is if we really want to call this on every "short read", > or just in case of ret < […] I think this makes sense (but I wonder what happens if we do not get a complete D_TSX_ALLOC_SIZE chunk. This means we would lose the incompletely read chunk?) https://gerrit.osmocom.org/c/libosmo-abis/+/32374/comment/1f8961ed_660dcb97 PS11, Line 391: osmo_fsm > likewise here, a SOCK_STREAM socket might in theory do a successful write of > any size, if the socket […] Done https://gerrit.osmocom.org/c/libosmo-abis/+/32374/comment/41a13cb0_5a6b5772 PS11, Line 414: osmo_fsm > same as above Done https://gerrit.osmocom.org/c/libosmo-abis/+/32374/comment/86787c9b_06a19796 PS11, Line 451: osmo_fsm > here I think the existing implementation is OK, as a HDLC socket is an > E1_TS_MODE_HDLCFCS socket, wh […] Yes, makes sense. https://gerrit.osmocom.org/c/libosmo-abis/+/32374/comment/29076305_5c9dff39 PS11, Line 476: osmo_fsm_inst_dispatch(g_e1d_fsm_inst, EV_CONN_LOST, line); > I'm not sure about the exact semantics of SOCK_SEQPACKET here, but I would > assume that a zero-length […] Yes, I think so too. (I have now changed the if above) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iaf4d42c2f009b1d7666e319fabdeb2598aa0b338 Gerrit-Change-Number: 32374 Gerrit-PatchSet: 12 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: keith <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-CC: tnt <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: keith <[email protected]> Gerrit-Comment-Date: Wed, 10 May 2023 11:03:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
