Attention is currently required from: jolly.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/32655 )

Change subject: Support (optional) indication of NCH position in SI1 rest octets
......................................................................


Patch Set 2:

(2 comments)

File src/osmo-bsc/bts_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/32655/comment/b8d8d7d7_21cd8960
PS2, Line 1113: "nch-position num-blocks <1-7> first-block <0-6>",
> These are actually 5 arguments, but here are only 3 descriptions of them.
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/32655/comment/19bf3d62_cd0ef13a
PS2, Line 1114: "NCH (Notification Channel) position within CCCH"
> Missing \n to separate descriptions.
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32655
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iefde0af44a663f22462a54d68a58caa560eceb2f
Gerrit-Change-Number: 32655
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Comment-Date: Wed, 10 May 2023 15:13:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <[email protected]>
Gerrit-MessageType: comment

Reply via email to