Attention is currently required from: jolly, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32693 )
Change subject: pcu_sock: fix PCUIF interface (PCH) ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/32693/comment/5246f344_14d92fbf PS1, Line 559: return pcu_rx_rr_imm_ass(bts, pag_grp, pch_dt); if this function is only used for PCH, then please rename it to contain "_pch". https://gerrit.osmocom.org/c/osmo-bsc/+/32693/comment/139355b2_e1873f58 PS1, Line 560: return pcu_rx_rr_paging(bts, pag_grp, pch_dt); same here, add _pch to it please. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32693 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I82443f2b402aa2416469c8c50b1c050323ef3b8f Gerrit-Change-Number: 32693 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: jolly <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Mon, 15 May 2023 11:52:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
