Attention is currently required from: osmith, laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32532 )
Change subject: pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 (Settable) ...................................................................... Patch Set 15: (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/32532/comment/a37783d5_3021c526 PS8, Line 11: Older versions will ignore the settable_object parameter > I think I will try this out. […] I don't see how extending the jenkins job would help here. In `contrib/jenkins.sh` we're executing the unit tests and `pySim-{prog,read}.py`. AFAICS, `pySim-shell.py` is not being executed, so this will unlikely help with catching compatibility issues. Someone will need to extend the testing coverage first, for instance by running `pySim-shell.py` scripts against real SIM cards (like we already do). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I38efe4702277ee092a5542d7d659df08cb0adeff Gerrit-Change-Number: 32532 Gerrit-PatchSet: 15 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Mon, 15 May 2023 14:05:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
