Attention is currently required from: dexter. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32711 )
Change subject: codec cosmetic: move old FR ECU code to ecu_fr_old.c ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > We probably might consider replacing the old implementation rather than > having two. The problem is that the two functions and their associated state structure that form the old implementation are all public API, and it was my understanding that per libosmocore policy, old public APIs are never removed, only marked as deprecated. Even if we decide to make an exception to that policy in the present case, gapk would need to be changed first to not use the old API, as it still does to the present day. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia169b8bcc6331227a11b78eb7ffca0c7ab838c69 Gerrit-Change-Number: 32711 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Mon, 15 May 2023 16:41:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
