Attention is currently required from: laforge, pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32110 )
Change subject: common+trx: make uplink ECU optional ...................................................................... Patch Set 5: (4 comments) Patchset: PS1: > I actually came to the same conclusion myself. […] Done File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/32110/comment/9e8e8c4e_49ee8d5d PS4, Line 809: bts->suppress_ul_ecu = false; > I wrote the code the way I did so that the default of having this UL ECU > enabled would happen on its […] Done File src/osmo-bts-trx/l1_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/32110/comment/8c4cfd7e_086f9347 PS4, Line 445: if (!trx->bts->suppress_ul_ecu) > if (trx->bts->use_ul_ecu) Done https://gerrit.osmocom.org/c/osmo-bts/+/32110/comment/81e5e9ea_ff275dbd PS4, Line 481: if (!trx->bts->suppress_ul_ecu) > if (trx->bts->use_ul_ecu) Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0acca9c6d7da966a623287563e0789db9e0fae8e Gerrit-Change-Number: 32110 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 16 May 2023 00:58:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
