Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/32730 )
Change subject: README.md: Document generation of SBcAP code from ASN.1 files ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File README.md: https://gerrit.osmocom.org/c/osmo-cbc/+/32730/comment/a4062eae_079c8a50 PS1, Line 75: Upstream master as1nc from [vlm](https://github.com/vlm/asn1c) [doesn't support APER encoding](https://github.com/vlm/asn1c/issues/452). Nevertheless, the upstream fork maintained by a big contributor [mouse07410](https://github.com/mouse07410/asn1c) does support it, and it is used in osmo-cbc to generate the SBc-AP code from ASN.1 files present in src/sbcap/asn1/. break lines at a similar length as above for consistency (maybe ~80)? https://gerrit.osmocom.org/c/osmo-cbc/+/32730/comment/4ffe6198_e144182f PS1, Line 77: regente regenerate -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/32730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id6edb2dcbd39ca101110f1ca57fcd67bf08c0ef0 Gerrit-Change-Number: 32730 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 16 May 2023 10:32:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
