Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32630 )
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload ...................................................................... Patch Set 3: (2 comments) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32630/comment/bece4b45_1b5af44f PS2, Line 1963: if (OSMO_UNLIKELY(rfc5993 && !ts101318 && rtp_pl_len == GSM_HR_BYTES_RTP_TS101318)) { > I'd really appreciate a more "step by step logic procedure" here, as in how > one would thing about it […] Done https://gerrit.osmocom.org/c/osmo-bts/+/32630/comment/9d91398d_c43009d8 PS2, Line 1970: } else if (OSMO_UNLIKELY(ts101318 && !rfc5993 && rtp_pl_len == GSM_HR_BYTES_RTP_RFC5993)) { > else not needed due to break immediatelly above. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9419b40c1171876879d41aba4f51c93e8ef5673c Gerrit-Change-Number: 32630 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 17 May 2023 14:06:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
