Attention is currently required from: lynxis lazus.

daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32514 )

Change subject: Use GSUP APN as Service-Selection field
......................................................................


Patch Set 3:

(1 comment)

File src/server_cb.erl:

https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32514/comment/c794d748_760461f5
PS3, Line 152:                       'Service-Selection' = 
maps:get(access_point_name, GsupPdpInfo)
Don't you need to call decode_apn here as well?



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32514
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo_dia2gsup
Gerrit-Branch: master
Gerrit-Change-Id: I2a0af5d785ce62968f6e3952602d92cb4f37e4ab
Gerrit-Change-Number: 32514
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: daniel <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Tue, 23 May 2023 10:17:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to