Attention is currently required from: pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510 )
Change subject: HLR_Tests: add testcase for multiple APNs in subscriber data ...................................................................... Patch Set 6: (1 comment) File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510/comment/789f2fce_be8aacdc PS6, Line 1037: tr_GSUP_IE_APN('08'O & char2oct("internet")) > can we please have a "function str2apn(charstring str) return octetstring" > for this please? :) It makes it a lot more complicated. It is length encoded by dots. (in python syntax) E.g. internet -> b"\x08internet" internet.fast -> b"\x08internet\x04fast". I would keep it as simple here for now.. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d0c08272bc239370e800d6014ab9c68087b8989 Gerrit-Change-Number: 32510 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 23 May 2023 11:50:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
