Attention is currently required from: falconia, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32962 )
Change subject: gsm0503_tch_hr_decode2(): new function, emits TS101318 format ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File src/coding/gsm0503_coding.c: https://gerrit.osmocom.org/c/libosmocore/+/32962/comment/96b979e9_f29c0d7f PS3, Line 1979: symbols of 8 bursts Not related to this patch, but worth mentioning: this is incorrect and probably was copy-pasted from `gsm0503_tch_fr_decode()`. For TCH/H (to be precise, for FACCH/H) the interleaving buffer is 6 bursts wide. I will submit a patch fixing this on top of your patchset to avoid conflicts. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32962 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If28ddb20789e8993b7558ca08020478615b4c708 Gerrit-Change-Number: 32962 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: falconia <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 23 May 2023 18:06:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
