Attention is currently required from: fixeria, dexter.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/32963 )
Change subject: ts_51_011: Add sst_service_[de]{activate,allocate} shell
commands
......................................................................
Patch Set 1:
(2 comments)
File pySim/ts_51_011.py:
https://gerrit.osmocom.org/c/pysim/+/32963/comment/57d682a0_2cf27d77
PS1, Line 696: !=
> Not critical, but it's recommended to use `is`/`is not` when comparing to
> `None`. […]
Done
https://gerrit.osmocom.org/c/pysim/+/32963/comment/f6eba4bf_b3bac348
PS1, Line 701: !=
> Same here.
Done
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/32963
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: If959d06248cb1a9d2c0a21cdd40d438726cbc5f0
Gerrit-Change-Number: 32963
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Tue, 23 May 2023 18:59:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment
