dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32719 )
Change subject: WIP: apply pylinth on cmd2 1.5 and later versions seperately ...................................................................... Patch Set 4: (2 comments) This change is ready for review. Patchset: PS4: My approach seems to be problematic. Not sure if it makes sense to take the effort to debug this. File contrib/jenkins.sh: https://gerrit.osmocom.org/c/pysim/+/32719/comment/dcff107e_728daba0 PS4, Line 36: pip uninstall -y cmd2 I am getting error messages around the pip install/uninstall commandlines. In particular: + [ ! -d ./pysim-testdata/ ] + pip uninstall -y cmd2 Skipping cmd2 as it is not installed. This does not make sense. Pylint should need a cmd2 version to be installed in order to do the linting. How can it even complain about things like constructor arguments when cmd2 is not installed? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32719 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I129b8c90ac80d75e125c81f5d5028fae3e295e6d Gerrit-Change-Number: 32719 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 24 May 2023 08:41:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
