Attention is currently required from: falconia.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/33063 )
Change subject: coding: gsm0503_tch_{fr,hr}_encode(): add ability to emit BFI
......................................................................
Patch Set 1:
(1 comment)
File src/coding/gsm0503_coding.c:
https://gerrit.osmocom.org/c/libosmocore/+/33063/comment/18b8746c_443aefc0
PS1, Line 1955: osmo_con
but how would this work for EFR? As we can see, this function is used to treat
EFR and FR cases, depending on the length of the frame. You are now
unconditionally encoding a FR frame. But what about the situation where EFR is
used?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33063
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iade3310e16b906efb6892d28f474a0d15204e861
Gerrit-Change-Number: 33063
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: falconia <[email protected]>
Gerrit-Comment-Date: Sat, 27 May 2023 10:16:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
