Patch Set 4: That looks like lot's of code duplication. Can we just set error string and call some generic function with it as parameter? Smth like case CTRL_TRAP: handle_incoming("TRAP",...)...
-- To view, visit https://gerrit.osmocom.org/5439 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic25a251502499aeda4e2952ec4190a1fa0bebb01 Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-HasComments: No