Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33001 )
Change subject: gmm: Implement rx GMM STATUS msg ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > btw, it might make sense to do all that kind of logging in a generic place > before dispatching to ind […] You can go even more generic than the "Rx foobar" and "msg_size check" by doing the tlv_parse in the generic part before dispatching to the per-message-type call-back. we even have code somewhere that contains the information about which msg_type requies which mandatory IEs. See osmo_tlv_prot_def. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I46719a3bf6d5e93e25f41f01f5c2ab889ff62803 Gerrit-Change-Number: 33001 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 29 May 2023 12:45:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
