Patch Set 3: (1 comment)
https://gerrit.osmocom.org/#/c/5038/3/scripts/osmodumpdoc.py File scripts/osmodumpdoc.py: Line 51: print("Skipping app %s" % appname, file=sys.stderr) With the "from future" import, does this now work in py2? I am still asking myself why you want to make the py2 scripts py3 compatible in the first place, and would welcome if you could answer this question I've raised a couple times now. We already have a py3 version of osmodumpdoc as osmo_interact_vty.py --gen-xml-ref [...] The osmodumpdoc.py script should not be installed by py3 since https://gerrit.osmocom.org/4312 -- To view, visit https://gerrit.osmocom.org/5038 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80e5850a8978d78cda793e2192ef4bd3fd54a121 Gerrit-PatchSet: 3 Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
