Patch Set 1: Code-Review-1 (2 comments)
Let me revisit this one; VTY and cleanup extensions might go in separate patch submissions... https://gerrit.osmocom.org/#/c/5381/1/src/iu_client.c File src/iu_client.c: Line 182: llist_for_each_entry(e, &rnc->lac_rac_list, entry) { > we typically introduce a helper function for the look-up. You have this in ack Line 195: llist_add(&e->entry, &rnc->lac_rac_list); > so we always keep adding RAC+LAC to the list but don't ever remove them. T my idea was that the effort to save LACs for an RNC Id is far less than placing more hNodeBs to attach to the HNBGW... but agreed, there should be *some* way to get rid of them. About re-attaching a LAC to another HNBGW, gotcha, I think I'm not handling that one properly. -- To view, visit https://gerrit.osmocom.org/5381 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I189f8e2663353276b1c615d2f78455dafe568045 Gerrit-PatchSet: 1 Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
