Attention is currently required from: pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/33094 )

Change subject: libosmogsm: Add support for TUAK authentication algorithm
......................................................................


Patch Set 5:

(3 comments)

File include/osmocom/crypt/auth.h:

https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a49e2579_58a27d2e
PS5, Line 36:   OSMO_AUTH_ALG_TUAK,
> update TODO-RELEASE (new symbols).
not really a "symbol", but yes it would count as API addition to libversion,I 
guess.


File src/gsm/auth_tuak.c:

https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ca6b942b_9045aa68
PS5, Line 45:   } else
> if {} else {}. […]
Done


File tests/Makefile.am:

https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e11941eb_c811f682
PS5, Line 401:       auth/milenage_test.ok                                      
\
> this looks wrong?
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d
Gerrit-Change-Number: 33094
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 30 May 2023 19:39:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to