Attention is currently required from: neels.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32991 )

Change subject: add startup config tests
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

File tests/Makefile.am:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/32991/comment/362cce0c_c0aee433
PS5, Line 69:   $(srcdir)/config/run_tests.sh 
"$(top_builddir)/src/osmo-hnbgw/osmo-hnbgw" "$(srcdir)/config/" $U
I fail to see why cannot you add the for loop directly here, I would expect the 
entire target is run by only 1 executor and be done sequentially.



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32991
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ic8bb30e1dd73753c2ff255566382e241918414f7
Gerrit-Change-Number: 32991
Gerrit-PatchSet: 5
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Comment-Date: Wed, 31 May 2023 08:43:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to