Attention is currently required from: tobias.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/33080 )

Change subject: modem_atcmd: make card reset cards.py compatible
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File pySim/transport/modem_atcmd.py:

https://gerrit.osmocom.org/c/pysim/+/33080/comment/170b8f52_bb5aa2ff
PS1, Line 39:         self._atr = []
serial.py initializes this with None. Is there a specific reason to change this?



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33080
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I79d0fc87919efae4ee89881b7840c0e809bd7918
Gerrit-Change-Number: 33080
Gerrit-PatchSet: 1
Gerrit-Owner: tobias <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: tobias <[email protected]>
Gerrit-Comment-Date: Thu, 01 Jun 2023 16:08:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to