Attention is currently required from: laforge.

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/33098 )

Change subject: db: extend database schema to support 256bit K and/or OP[c] 
values
......................................................................


Patch Set 4:

(3 comments)

File src/db.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/33098/comment/fb60d742_5e9d6495
PS4, Line 550: 6
7

(last time i worked on this i considered having a LOGP("%d", version) because 
it's easy to make this copy paste mistake and not notice; i guess i decided 
against it)


File src/hlr_vty_subscr.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/33098/comment/c50ae12f_57ba031a
PS4, Line 479:   * below for real 3G AKA algorithms. */
(120 line width)


https://gerrit.osmocom.org/c/osmo-hlr/+/33098/comment/9dab5afa_6aa1c6ac
PS4, Line 510:                  *maxlen_opc = MILENAGE_KEY_LEN;
will there ever be minlen_opc < maxlen_opc?



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33098
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ibbde68484c904507a15c35cbfdf88cd47d0c7039
Gerrit-Change-Number: 33098
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-CC: neels <nhofm...@sysmocom.de>
Gerrit-Attention: laforge <lafo...@osmocom.org>
Gerrit-Comment-Date: Mon, 05 Jun 2023 22:39:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to